yahoo-eng-team team mailing list archive

[OpenStack Infra <1871287@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/717947
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9f5948bef8f4bbeaecd78e54e6a0dd1c70cbe3c3
Submitter: Zuul
Branch:    master

commit 9f5948bef8f4bbeaecd78e54e6a0dd1c70cbe3c3
Author: Ghanshyam Mann <gmann@xxxxxxxxxxxxxxxxx>
Date:   Mon Apr 6 23:52:40 2020 -0500

    Fix server tags policy to be admin_or_owner
    
    server tags API policy is default to admin_or_owner[1] but API
    is allowed for everyone.
    
    We can see the test trying with other project context can access the API
    - https://review.opendev.org/#/c/717425
    
    This is because API does not pass the server project_id in policy target[2]
    and if no target is passed then, policy.py add the default targets which is
    nothing but context.project_id (allow for everyone who try to access).
    
    This commit fix this policy by passing the server's project_id in policy
    target.
    
    Closes-bug: #1871287
    Partial implement blueprint policy-defaults-refresh
    
    [1] https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/policies/server_tags.py#L27
    [2] https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/api/openstack/compute/server_tags.py#L88
    
    Change-Id: I0718fd16d91b5d208a62f6ced1cb45c1738ab96c


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1871287

Title:
  server tags  API policy is allowed for everyone even policy defaults
  is admin_or_owner

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  server tags API policy is default to admin_or_owner[1] but API is
  allowed for everyone.

  We can see the test trying with other project context can access the API
  - https://review.opendev.org/#/c/717425

  This is because API does not pass the server project_id in policy target
  - https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/api/openstack/compute/server_tags.py#L88

  and if no target is passed then, policy.py add the default targets which is nothing but context.project_id (allow for everyone try to access)
  - https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191

  [1]
  - https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/policies/server_tags.py#L27

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1871287/+subscriptions