yahoo-eng-team team mailing list archive

[OpenStack Infra <1890353@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/744809
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=c8703df185ae3a3445e1e3368ee3229f485b85d9
Submitter: Zuul
Branch:    master

commit c8703df185ae3a3445e1e3368ee3229f485b85d9
Author: Sean Mooney <work@xxxxxxxxxxxxxxx>
Date:   Wed Aug 5 00:07:11 2020 +0000

    support pyroute2 0.5.13
    
    This change modifes os-vif add interface to account
    for the new behavior of link_lookup.
    In 0.5.13 if a link is not found link_lookup returns an
    empty list. In previous releases it raised ipexc.NetlinkError.
    
    Closes-bug: #1890353
    
    Change-Id: I567afb544425c1b91d98968a0b597be718869089


** Changed in: os-vif
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1890353

Title:
  support pyroute2 0.5.13

Status in neutron:
  In Progress
Status in os-vif:
  Fix Released

Bug description:
  pytroute2 version 0.5.13 changed the behaviour of ip.link_lookup
  such that if the device is not found it now returns an empty list instead
  of raising ipexc.NetlinkError.

  as we have unit test that assert the old behaviour this breaks the os-vif unit tests.
  recently https://review.opendev.org/#/c/743277/ was merged to bump the pytroute2 version
  but the requirements repo does not currently run the os-vif unit test so this breakage was not seen.

  https://review.opendev.org/#/c/744803/1 adds a new cross job to track
  that but os-vif should also be updated to account for the new
  behaviour.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1890353/+subscriptions