yahoo-eng-team team mailing list archive

[OpenStack Infra <1890353@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/744956
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e5ce19318921c44f2f5ed4568b31b04d82a17fd4
Submitter: Zuul
Branch:    master

commit e5ce19318921c44f2f5ed4568b31b04d82a17fd4
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Aug 5 17:36:01 2020 +0000

    Support pyroute2 0.5.13
    
    Since [1], pyroute2 0.5.13 is supported.
    
    In this new version, "link_lookup" do not raise a NetlinkError
    exception if the device does not exist; instead returns an empty
    list.
    
    This patch handles both implementations.
    
    [1]https://review.opendev.org/#/c/743277/
    
    Change-Id: I77ef374ecb776966ea13499755777e2d763d884b
    Closes-Bug: #1890353


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1890353

Title:
  support pyroute2 0.5.13

Status in neutron:
  Fix Released
Status in os-vif:
  Fix Released

Bug description:
  pytroute2 version 0.5.13 changed the behaviour of ip.link_lookup
  such that if the device is not found it now returns an empty list instead
  of raising ipexc.NetlinkError.

  as we have unit test that assert the old behaviour this breaks the os-vif unit tests.
  recently https://review.opendev.org/#/c/743277/ was merged to bump the pytroute2 version
  but the requirements repo does not currently run the os-vif unit test so this breakage was not seen.

  https://review.opendev.org/#/c/744803/1 adds a new cross job to track
  that but os-vif should also be updated to account for the new
  behaviour.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1890353/+subscriptions