yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #84004
[Bug 1896920] [NEW] Unnecessary error log when checking if a device is ready
Public bug reported:
In method "ensure_device_is_ready" [1], if the device does not exist or
the MAC is still not assigned, the method returns False and also logs an
error. This error log is distracting; instead of this, an info message
could be logged.
The code using this method, that returns True or False depending on the
state of the interface, can decide to log a higher log message.
[1]https://github.com/openstack/neutron/blob/856cae4cf8e33c05b308d880df78b7be02ae90ad/neutron/agent/linux/ip_lib.py#L955
** Affects: neutron
Importance: Wishlist
Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
Status: In Progress
** Changed in: neutron
Importance: Undecided => Low
** Changed in: neutron
Importance: Low => Wishlist
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1896920
Title:
Unnecessary error log when checking if a device is ready
Status in neutron:
In Progress
Bug description:
In method "ensure_device_is_ready" [1], if the device does not exist
or the MAC is still not assigned, the method returns False and also
logs an error. This error log is distracting; instead of this, an info
message could be logged.
The code using this method, that returns True or False depending on
the state of the interface, can decide to log a higher log message.
[1]https://github.com/openstack/neutron/blob/856cae4cf8e33c05b308d880df78b7be02ae90ad/neutron/agent/linux/ip_lib.py#L955
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1896920/+subscriptions
Follow ups