yahoo-eng-team team mailing list archive

[OpenStack Infra <1896920@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/754005
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c
Submitter: Zuul
Branch:    master

commit b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Sep 23 16:35:45 2020 +0000

    Reduce log level in "ensure_device_is_ready"
    
    If the device is not ready, the method should inform about this
    event. The code calling this method, if needed, can write a higher
    log message.
    
    Change-Id: Ib7c5ba736f6e4ccc88df665faeef304c176a24e7
    Closes-Bug: #1896920


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1896920

Title:
  Unnecessary error log when checking if a device is ready

Status in neutron:
  Fix Released

Bug description:
  In method "ensure_device_is_ready" [1], if the device does not exist
  or the MAC is still not assigned, the method returns False and also
  logs an error. This error log is distracting; instead of this, an info
  message could be logged.

  The code using this method, that returns True or False depending on
  the state of the interface, can decide to log a higher log message.

  [1]https://github.com/openstack/neutron/blob/856cae4cf8e33c05b308d880df78b7be02ae90ad/neutron/agent/linux/ip_lib.py#L955

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1896920/+subscriptions