yahoo-eng-team team mailing list archive

[Sylvain Bauza <1902925@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

In change https://review.opendev.org/#/c/715326/ we allowed a new
argument to the rebuild_instance() RPC method named 'accel_uuids'.

In the same change, in order to manage different version of computes, we allowed to not pass this argument if the destination RPC service is not able to speak 5.12.
That being said, as we forgot to make the accel_uuids argument be nullable, we then accordingly cast a call to the compute manager without this attribute while it expects it, which would lead to a TypeError on the server side.

FWIW, this can happen with any RPC pin, even with the compute='auto'
default value as this value will elect to automatically pin a version
that both the source and destination can support.

** Affects: nova
     Importance: Critical
     Assignee: Sylvain Bauza (sylvain-bauza)
         Status: Confirmed

** Affects: nova/victoria
     Importance: Critical
     Assignee: Sylvain Bauza (sylvain-bauza)
         Status: Confirmed


** Tags: compute upgrade

** Changed in: nova
       Status: New => Confirmed

** Changed in: nova
   Importance: Undecided => High

** Changed in: nova
   Importance: High => Critical

** Also affects: nova/victoria
   Importance: Undecided
       Status: New

** Changed in: nova/victoria
   Importance: Undecided => Critical

** Changed in: nova
     Assignee: (unassigned) => Sylvain Bauza (sylvain-bauza)

** Changed in: nova/victoria
     Assignee: (unassigned) => Sylvain Bauza (sylvain-bauza)

** Changed in: nova/victoria
       Status: New => Confirmed

** Tags added: compute upgrade

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1902925

Title:
  Upgrades to compute RPC API 5.12 are broken

Status in OpenStack Compute (nova):
  Confirmed
Status in OpenStack Compute (nova) victoria series:
  Confirmed

Bug description:
  In change https://review.opendev.org/#/c/715326/ we allowed a new
  argument to the rebuild_instance() RPC method named 'accel_uuids'.

  In the same change, in order to manage different version of computes, we allowed to not pass this argument if the destination RPC service is not able to speak 5.12.
  That being said, as we forgot to make the accel_uuids argument be nullable, we then accordingly cast a call to the compute manager without this attribute while it expects it, which would lead to a TypeError on the server side.

  FWIW, this can happen with any RPC pin, even with the compute='auto'
  default value as this value will elect to automatically pin a version
  that both the source and destination can support.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1902925/+subscriptions