yahoo-eng-team team mailing list archive

[OpenStack Infra <1902925@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/761458
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8d9f298f4c48e32bc625c7e2f47d47e4277ec064
Submitter: Zuul
Branch:    master

commit 8d9f298f4c48e32bc625c7e2f47d47e4277ec064
Author: Sylvain Bauza <sbauza@xxxxxxxxxx>
Date:   Wed Nov 4 20:20:52 2020 +0100

    Fix the compute RPC 5.12 issue
    
    In I147bf4d95e6d86ff1f967a8ce37260730f21d236 we added a new argument for
    the rebuild_instance() RPC method. Unfortunately, we missed to that it
    needs to be optional for older versions.
    
    Adding a default none value for it so rolling upgrades would work.
    
    Change-Id: I59c5e56b00114fea5ec19fa63ec73f032dc3bd5c
    Closes-Bug: #1902925


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1902925

Title:
  Upgrades to compute RPC API 5.12 are broken

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) victoria series:
  In Progress

Bug description:
  In change https://review.opendev.org/#/c/715326/ we allowed a new
  argument to the rebuild_instance() RPC method named 'accel_uuids'.

  In the same change, in order to manage different version of computes, we allowed to not pass this argument if the destination RPC service is not able to speak 5.12.
  That being said, as we forgot to make the accel_uuids argument be nullable, we then accordingly cast a call to the compute manager without this attribute while it expects it, which would lead to a TypeError on the server side.

  FWIW, this can happen with any RPC pin, even with the compute='auto'
  default value as this value will elect to automatically pin a version
  that both the source and destination can support.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1902925/+subscriptions