yahoo-eng-team team mailing list archive

[Balazs Gibizer <1932268@xxxxxxxxxxxxxxxxxx>]

What do you suggests? What state should the VM be in after a failed
restore? The VM is still soft-deleted on the hypervisor as the restore
is failed and no task is ongoing as that restore task failed. For me it
is the expected behavior that if the restore fails and then the reclaim
timer hits then the VM is deleted.

Closing this as Invalid. Please set it back to New if you disagree.

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1932268

Title:
  soft deleted instance is deleted when error restoring

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  
  The SOFT_DELETED instance will be deleted when executing restore instance failed.

  restore instance:
  instance.task_state = task_states.RESTORING
  instance.deleted_at = None

  If `self.driver.restore(instance)` or `self._power_on(context,
  instance)` in `nova/compute/manager.py` execute failed,
  instance.task_state will revert to None due to `@reverts_task_state`.

  The instance will be filtered in _reclaim_queued_deletes task and will
  be deleted incorrectly.

  filters = {'vm_state': vm_states.SOFT_DELETED,
             'task_state': None,
             'host': self.host}

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1932268/+subscriptions