yahoo-eng-team team mailing list archive

[HYSong <1932268@xxxxxxxxxxxxxxxxxx>]

I suggest to execute 'instance.deleted_at = None' after
self.driver.restore(instance) or self._power_on(context, instance)
finished, and the vm will not be deleted when restoring failed.

** Changed in: nova
       Status: Invalid => New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1932268

Title:
  soft deleted instance is deleted when error restoring

Status in OpenStack Compute (nova):
  New

Bug description:
  
  The SOFT_DELETED instance will be deleted when executing restore instance failed.

  restore instance:
  instance.task_state = task_states.RESTORING
  instance.deleted_at = None

  If `self.driver.restore(instance)` or `self._power_on(context,
  instance)` in `nova/compute/manager.py` execute failed,
  instance.task_state will revert to None due to `@reverts_task_state`.

  The instance will be filtered in _reclaim_queued_deletes task and will
  be deleted incorrectly.

  filters = {'vm_state': vm_states.SOFT_DELETED,
             'task_state': None,
             'host': self.host}

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1932268/+subscriptions