← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1957931] [NEW] OVS: except MappingNotFound instead of KeyError

 

Public bug reported:

LocalVlanManager.pop() swallows KeyError to raise MappingNotFound:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/vlanmanager.py#L110

OVSNeutronAgent.reclaim_local_vlan() excepts a KeyError:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1064

Which breaks the loop in treat_devices_removed():
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2053

** Affects: neutron
     Importance: Undecided
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1957931

Title:
  OVS: except MappingNotFound instead of KeyError

Status in neutron:
  In Progress

Bug description:
  LocalVlanManager.pop() swallows KeyError to raise MappingNotFound:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/vlanmanager.py#L110

  OVSNeutronAgent.reclaim_local_vlan() excepts a KeyError:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1064

  Which breaks the loop in treat_devices_removed():
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2053

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1957931/+subscriptions



Follow ups