yahoo-eng-team team mailing list archive

[OpenStack Infra <1957931@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/824727
Committed: https://opendev.org/openstack/neutron/commit/d033c9f93327b5845280bbc21e5a229555b905f4
Submitter: "Zuul (22348)"
Branch:    master

commit d033c9f93327b5845280bbc21e5a229555b905f4
Author: jpic <jpic@xxxxxxxxxxxx>
Date:   Fri Jan 14 16:31:22 2022 +0100

    Fix OVS OVSNeutronAgent.reclaim_local_vlan()
    
    Closes-Bug: #1957931
    
    Change-Id: I5b716399cb8344b8a89b97378fcb4796654e6152


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1957931

Title:
  OVS: except MappingNotFound instead of KeyError

Status in neutron:
  Fix Released

Bug description:
  LocalVlanManager.pop() swallows KeyError to raise MappingNotFound:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/vlanmanager.py#L110

  OVSNeutronAgent.reclaim_local_vlan() excepts a KeyError:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1064

  Which breaks the loop in treat_devices_removed():
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2053

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1957931/+subscriptions