yahoo-eng-team team mailing list archive

[Rodolfo Alonso <1960533@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The log API service, when RPC is required, always writes errors in the logs. Example:
/var/log/containers/neutron/server.log.1:77743:2022-02-09 15:00:07.436 17 ERROR neutron.services.logapi.drivers.manager [req-8bd18cf3-2ac3-46f0-a718-8a67be4a2331 3a57a60f73c44b82afbe0384a9fd52fa 3270928a80dc444fb5b471d2927544e9 - default default] Method create_log_precommit is not implemented in logging RPC


This is because the default RPC server implementation, "LoggingApiNotification" [1], does not implement all the methods implemented by the "DriverBase" [2]. When a method of the driver is called, if the RPC is required, the same method will be called in the RPC server.

This is a cosmetic change, the service works. But having by design an
error in the log messages is not a good implementation.


[1]https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/rpc/server.py#L102
[2]https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/drivers/base.py#L27

** Affects: neutron
     Importance: Low
         Status: New

** Changed in: neutron
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1960533

Title:
  Logging service writting errors in the logs when RPC required

Status in neutron:
  New

Bug description:
  The log API service, when RPC is required, always writes errors in the logs. Example:
  /var/log/containers/neutron/server.log.1:77743:2022-02-09 15:00:07.436 17 ERROR neutron.services.logapi.drivers.manager [req-8bd18cf3-2ac3-46f0-a718-8a67be4a2331 3a57a60f73c44b82afbe0384a9fd52fa 3270928a80dc444fb5b471d2927544e9 - default default] Method create_log_precommit is not implemented in logging RPC

  
  This is because the default RPC server implementation, "LoggingApiNotification" [1], does not implement all the methods implemented by the "DriverBase" [2]. When a method of the driver is called, if the RPC is required, the same method will be called in the RPC server.

  This is a cosmetic change, the service works. But having by design an
  error in the log messages is not a good implementation.

  
  [1]https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/rpc/server.py#L102
  [2]https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/drivers/base.py#L27

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1960533/+subscriptions