yahoo-eng-team team mailing list archive

[OpenStack Infra <1960533@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/829522
Committed: https://opendev.org/openstack/neutron/commit/1aeef5a74e82e97cbed7d65a1f824dbb3070af08
Submitter: "Zuul (22348)"
Branch:    master

commit 1aeef5a74e82e97cbed7d65a1f824dbb3070af08
Author: Nurmatov Mamatisa <nurmatov.mamatisa@xxxxxxxxxx>
Date:   Wed Feb 16 14:07:02 2022 +0300

    Add new class for Logging API methods
    
    Not all logapi "DriverBase" [1] methods are implemented in
    rpc "LoggingApiNotification" [2]
    Now above classes  inherit from class 'LoggingApiBase'
    
    [1] https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/drivers/base.py#L27
    [2]
    https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/rpc/server.py#L102
    
    Closes-bug: #1960533
    Change-Id: I9fbfa0f823bcdde60910b018ef2a8fdffaf3512c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1960533

Title:
  Logging service writing errors in the logs when RPC required

Status in neutron:
  Fix Released

Bug description:
  The log API service, when RPC is required, always writes errors in the logs. Example:
  /var/log/containers/neutron/server.log.1:77743:2022-02-09 15:00:07.436 17 ERROR neutron.services.logapi.drivers.manager [req-8bd18cf3-2ac3-46f0-a718-8a67be4a2331 3a57a60f73c44b82afbe0384a9fd52fa 3270928a80dc444fb5b471d2927544e9 - default default] Method create_log_precommit is not implemented in logging RPC

  
  This is because the default RPC server implementation, "LoggingApiNotification" [1], does not implement all the methods implemented by the "DriverBase" [2]. When a method of the driver is called, if the RPC is required, the same method will be called in the RPC server.

  This is a cosmetic change, the service works. But having by design an
  error in the log messages is not a good implementation.

  
  [1]https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/rpc/server.py#L102
  [2]https://github.com/openstack/neutron/blob/cf0cc1f4f262994db1044431fc9142745f2a757b/neutron/services/logapi/drivers/base.py#L27

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1960533/+subscriptions