yahoo-eng-team team mailing list archive

[Takashi Kajinami <1967683@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Currently, remote_address attribute of the Reqeust object is used to
look up client address in multiple places.

eg.
https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64

~~~
def _set_request_context(req, **kwargs):
    """Sets request context based on parameters and request."""
    remote_address = getattr(req, 'remote_address', '127.0.0.1')
~~~

However, webob.Request has no remote_address attribute but only remote_addr attribute.
 https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr

** Affects: cinder
     Importance: Undecided
         Status: In Progress

** Affects: nova
     Importance: Undecided
         Status: New

** Also affects: nova
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1967683

Title:
  Wrong property to look up remote address

Status in Cinder:
  In Progress
Status in OpenStack Compute (nova):
  New

Bug description:
  Currently, remote_address attribute of the Reqeust object is used to
  look up client address in multiple places.

  eg.
  https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64

  ~~~
  def _set_request_context(req, **kwargs):
      """Sets request context based on parameters and request."""
      remote_address = getattr(req, 'remote_address', '127.0.0.1')
  ~~~

  However, webob.Request has no remote_address attribute but only remote_addr attribute.
   https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions