yahoo-eng-team team mailing list archive

[OpenStack Infra <1967683@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/cinder/+/836247
Committed: https://opendev.org/openstack/cinder/commit/90abed0a44bbf2c0c14169b670954a8f66831598
Submitter: "Zuul (22348)"
Branch:    master

commit 90abed0a44bbf2c0c14169b670954a8f66831598
Author: Takashi Kajinami <tkajinam@xxxxxxxxxx>
Date:   Mon Apr 4 00:11:49 2022 +0900

    Fix wrong attribute to find remote address
    
    The webob.Request class does not have the remote_address attribute but
    the remote_addr attribute. This change fixes usage of the non-existing
    attribute accordingly.
    
    Closes-Bug: #1967683
    Change-Id: I233d706d49c795e67f4cdb32ff7ef3e9cdd36b00


** Changed in: cinder
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1967683

Title:
  Wrong property to look up remote address

Status in Cinder:
  Fix Released
Status in ec2-api:
  Fix Released
Status in OpenStack Shared File Systems Service (Manila):
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Currently, remote_address attribute of the Reqeust object is used to
  look up client address in multiple places.

  eg.
  https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64

  ~~~
  def _set_request_context(req, **kwargs):
      """Sets request context based on parameters and request."""
      remote_address = getattr(req, 'remote_address', '127.0.0.1')
  ~~~

  However, webob.Request has no remote_address attribute but only remote_addr attribute.
   https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions