yahoo-eng-team team mailing list archive

[OpenStack Infra <1967686@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/manila/+/836251
Committed: https://opendev.org/openstack/manila/commit/b24fc87a1d26ce3447c5fc914f55fb199a2b7702
Submitter: "Zuul (22348)"
Branch:    master

commit b24fc87a1d26ce3447c5fc914f55fb199a2b7702
Author: Takashi Kajinami <tkajinam@xxxxxxxxxx>
Date:   Mon Apr 4 00:27:42 2022 +0900

    Deprecate [DEFAULT] use_forwarded_for
    
    ... because functionality of this parameter is effectively duplicate of
    the HTTPProxyToWSGI middleware in oslo.middleware library.
    
    Closes-Bug: #1967686
    Change-Id: I4db615093b739c7ff582f348a6fb6eabb8068257


** Changed in: manila
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1967686

Title:
  [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI
  middleware

Status in Cinder:
  In Progress
Status in OpenStack Shared File Systems Service (Manila):
  Fix Released
Status in OpenStack Compute (nova):
  In Progress

Bug description:
  The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header.
  However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library.

  Now the HTTPProxyToWSGI middleware is enabled in api pipeline by
  default, and also is globally used by multiple components, the own
  use_forwarded_for parameter can be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1967686/+subscriptions