yahoo-eng-team team mailing list archive

[OpenStack Infra <1967686@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/836253
Committed: https://opendev.org/openstack/nova/commit/cf906cdcc25c112956f56f9fb9f62b2cfdeacc65
Submitter: "Zuul (22348)"
Branch:    master

commit cf906cdcc25c112956f56f9fb9f62b2cfdeacc65
Author: Takashi Kajinami <tkajinam@xxxxxxxxxx>
Date:   Mon Apr 4 00:43:18 2022 +0900

    Deprecate [api] use_forwarded_for
    
    ... because functionality of this parameter is effectively duplicate of
    the HTTPProxyToWSGI middleware in oslo.middleware library.
    
    Closes-Bug: #1967686
    Change-Id: Ifebcfb6b5c1594c075bb9c152a06aa7af7c61bc8


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1967686

Title:
  [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI
  middleware

Status in Cinder:
  In Progress
Status in OpenStack Shared File Systems Service (Manila):
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header.
  However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library.

  Now the HTTPProxyToWSGI middleware is enabled in api pipeline by
  default, and also is globally used by multiple components, the own
  use_forwarded_for parameter can be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1967686/+subscriptions