yahoo-eng-team team mailing list archive

[OpenStack Infra <1969980@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/839227
Committed: https://opendev.org/openstack/nova/commit/aa1b0a7ccb1fcf3644784125bfff6950993e1697
Submitter: "Zuul (22348)"
Branch:    master

commit aa1b0a7ccb1fcf3644784125bfff6950993e1697
Author: Artom Lifshitz <alifshit@xxxxxxxxxx>
Date:   Mon Apr 25 10:20:14 2022 -0400

    Fix LM rollback w/o multi port bindings extension
    
    Previously, the libvirt driver's live migration rollback code would
    unconditionally refer to migrate_data.vifs. This field would only be
    set if the Neutron multiple port bindings extension was in use. When
    it is not in use, the reference would fail with a NotImplementedError.
    This patch wraps the migrate_data.vifs reference in a conditional that
    checks if the vifs field is actually set. This is the only way to do
    it, as in the libvirt driver we do not have access to the network
    API's has_port_binding_extension() helper.
    
    Closes-bug: 1969980
    Change-Id: I48ca6a77de38e3afaa44630e6ae1fd41d2031ba9


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1969980

Title:
  Live migration rollback fails if no Neutorn multiple port bindings
  extension

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  This is really a continuation of bug 1888395.

  Steps to reproduce
  ==================
  Have Neutron without multiple port bindings extension.
  Boot an instance with network interfaces.
  Live migrate, and fail the live migration somehow (easy to do in func tests)

  Expected result
  ===============
  Rollback happens correctly.

  Actual result
  =============
  Rollback fails with NotImplementedError: Cannot load 'vifs' in the base class

  
  Environment
  ===========
  Reported against stable/wallaby [1], still reproducible in func tests on master.

  [1] https://bugzilla.redhat.com/show_bug.cgi?id=2077964

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1969980/+subscriptions