yahoo-eng-team team mailing list archive

[OpenStack Infra <1975891@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/843565
Committed: https://opendev.org/openstack/nova/commit/3aa77a3999a7dcabbd4c0141d4c56b07a4624128
Submitter: "Zuul (22348)"
Branch:    master

commit 3aa77a3999a7dcabbd4c0141d4c56b07a4624128
Author: Rajesh Tailor <ratailor@xxxxxxxxxx>
Date:   Fri May 27 09:51:11 2022 +0530

    Add missing condition
    
    Change [1] added new fields 'src|dst_supports_numa_live_migration'
    to LibvirtLiveMigrateData object, but missed if condition for
    dst_supports_numa_live_migration field in obj_make_compatible
    method.
    
    This change adds the if condition as well as fix typo in unit test
    because of which this wasn't catched earlier.
    
    Closes-Bug: #1975891
    Change-Id: Ice5a2c7aca77f47ea6328a10d835854d9aff408e


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1975891

Title:
  Add missing if condition

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The change [1] added src|dst_supports_numa_live_migration fields to
  LibvirtLiveMigrateData object, where if condition for
  dst_supports_numa_live_migration is missing in obj_make_compatible
  method [2].

  This wasn't catched earlier because of typo in unit test [3].

  [1] https://opendev.org/openstack/nova/commit/71fafa5b19de98cbd2fb7b8e4a086521c9786638
  [2] https://opendev.org/openstack/nova/src/branch/master/nova/objects/migrate_data.py#L279-L283
  [3] https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/objects/test_migrate_data.py#L98

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1975891/+subscriptions