yahoo-eng-team team mailing list archive

[Rajesh Tailor <1975891@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The change [1] added src|dst_supports_numa_live_migration fields to
LibvirtLiveMigrateData object, where if condition for
dst_supports_numa_live_migration is missing in obj_make_compatible
method [2].

This wasn't catched earlier because of typo in unit test [3].

[1] https://opendev.org/openstack/nova/commit/71fafa5b19de98cbd2fb7b8e4a086521c9786638
[2] https://opendev.org/openstack/nova/src/branch/master/nova/objects/migrate_data.py#L279-L283
[3] https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/objects/test_migrate_data.py#L98

** Affects: nova
     Importance: Undecided
     Assignee: Rajesh Tailor (ratailor)
         Status: In Progress

** Changed in: nova
     Assignee: (unassigned) => Rajesh Tailor (ratailor)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1975891

Title:
  Add missing if condition

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  The change [1] added src|dst_supports_numa_live_migration fields to
  LibvirtLiveMigrateData object, where if condition for
  dst_supports_numa_live_migration is missing in obj_make_compatible
  method [2].

  This wasn't catched earlier because of typo in unit test [3].

  [1] https://opendev.org/openstack/nova/commit/71fafa5b19de98cbd2fb7b8e4a086521c9786638
  [2] https://opendev.org/openstack/nova/src/branch/master/nova/objects/migrate_data.py#L279-L283
  [3] https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/objects/test_migrate_data.py#L98

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1975891/+subscriptions