yahoo-eng-team team mailing list archive

[ZhouHeng <1978035@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

AgentCache method update[1] has a parameter "updated_at", I didn't find this parameter passed in anywhere except for some unit tests. currently we have used nb_cfg_timestamp[2] as agent updated time. there are no other scenarios for this parameter.
can we remove this parameter?

[1] https://opendev.org/openstack/neutron/src/commit/e44dbe98e82fddac72723caa9357daae0f0ab76f/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L241
[2] https://review.opendev.org/c/openstack/neutron/+/802834

** Affects: neutron
     Importance: Undecided
         Status: New

** Description changed:

- AgentCache method update[1] has a parameter "updated_at", I didn't find this parameter passed in anywhere except for some unit tests. currently we have used nb_cfg_timestamp[2] as agent updated time. 
+ AgentCache method update[1] has a parameter "updated_at", I didn't find this parameter passed in anywhere except for some unit tests. currently we have used nb_cfg_timestamp[2] as agent updated time. there are no other scenarios for this parameter.
  can we remove this parameter?
- 
  
  [1] https://opendev.org/openstack/neutron/src/commit/e44dbe98e82fddac72723caa9357daae0f0ab76f/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L241
  [2] https://review.opendev.org/c/openstack/neutron/+/802834

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1978035

Title:
  remove unused updated_at  parameter for AgentCache.update

Status in neutron:
  New

Bug description:
  AgentCache method update[1] has a parameter "updated_at", I didn't find this parameter passed in anywhere except for some unit tests. currently we have used nb_cfg_timestamp[2] as agent updated time. there are no other scenarios for this parameter.
  can we remove this parameter?

  [1] https://opendev.org/openstack/neutron/src/commit/e44dbe98e82fddac72723caa9357daae0f0ab76f/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L241
  [2] https://review.opendev.org/c/openstack/neutron/+/802834

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1978035/+subscriptions