yahoo-eng-team team mailing list archive

[OpenStack Infra <1978035@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/845184
Committed: https://opendev.org/openstack/neutron/commit/7dbc61346a89af1f4f4a002171f7f36a74034049
Submitter: "Zuul (22348)"
Branch:    master

commit 7dbc61346a89af1f4f4a002171f7f36a74034049
Author: zhouhenglc <zhouhenglc@xxxxxxxxxx>
Date:   Thu Jun 9 09:16:06 2022 +0800

    remove unused updated_at parameter for AgentCache.update
    
    we cannot find this parameter passed in anywhere except for some unit
    tests. currently we have used nb_cfg_timestamp[1] as agent updated
    time. there are no other scenarios for this parameter. this patch
    remove it and update some unit test.
    
    [1] https://review.opendev.org/c/openstack/neutron/+/802834
    
    Closes-bug: #1978035
    
    Change-Id: Ic964b7ddc70988bb1a822b07be6a1be4d197287e


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1978035

Title:
  remove unused updated_at  parameter for AgentCache.update

Status in neutron:
  Fix Released

Bug description:
  AgentCache method update[1] has a parameter "updated_at", I didn't find this parameter passed in anywhere except for some unit tests. currently we have used nb_cfg_timestamp[2] as agent updated time. there are no other scenarios for this parameter.
  can we remove this parameter?

  [1] https://opendev.org/openstack/neutron/src/commit/e44dbe98e82fddac72723caa9357daae0f0ab76f/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L241
  [2] https://review.opendev.org/c/openstack/neutron/+/802834

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1978035/+subscriptions