yahoo-eng-team team mailing list archive

[OpenStack Infra <1992186@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/keystone/+/860726
Committed: https://opendev.org/openstack/keystone/commit/c70d0c33a5977ca7208fbadd876a646cd37ffb31
Submitter: "Zuul (22348)"
Branch:    master

commit c70d0c33a5977ca7208fbadd876a646cd37ffb31
Author: Mohammed Naser <mnaser@xxxxxxxxxxxx>
Date:   Fri Oct 7 17:06:12 2022 +0000

    fix(federation): allow using numerical group names
    
    When using a numerical group name, the current codebase which
    relies on ast.literal_eval does not account for the value
    being a number.  Therefore, it can be parsed as a number and
    fail in further steps since it will not be a list.
    
    This patch adds a test to handle that use case and refactor the
    code that leverages ast.literal_eval to be the same everywhere
    so that it adds that fix everywhere.
    
    Closes-Bug: #1992186
    Change-Id: I665b7e0234650ba07e0d030a2d442d6599d0888a


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1992186

Title:
  "int object is not iterable" when using numerical group names

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  When using federation and having the values of `groups` in the mapping
  set to a number, it will be parsed into a a number and then fail to
  authenticate:

  ```
  {"error":{"code":400,"message":"'int' object is not iterable","title":"Bad Request"}}
  ```

  I believe the bad bit is here:

  https://github.com/openstack/keystone/blob/326b014434cc760ba08763e1870ac057f7917e98/keystone/federation/utils.py#L650-L661

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1992186/+subscriptions