yahoo-eng-team team mailing list archive

["StreSS.t" <2019314@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

This bug mimics https://bugs.launchpad.net/oslo.messaging/+bug/1606213.

In that bug, the path to oslo_messaging was added, but the close method
was not called in the linuxbridge agent

Example patch:

--- /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py.bak       2023-05-12 11:45:42.089121033 +0000
+++ /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py   2023-05-12 11:46:08.201490083 +0000
@@ -116,6 +116,7 @@
         if graceful and self.quitting_rpc_timeout:
             self.set_rpc_timeout(self.quitting_rpc_timeout)
         super(CommonAgentLoop, self).stop(graceful)
+        self.connection.close()

     def reset(self):
         common_config.setup_logging()

** Affects: neutron
     Importance: Undecided
         Status: New

** Description changed:

  This bug mimics https://bugs.launchpad.net/oslo.messaging/+bug/1606213.
  
  In that bug, the path to oslo_messaging was added, but the close method
  was not called in the linuxbridge agent
  
  Example patch:
  
  --- /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py.bak       2023-05-12 11:45:42.089121033 +0000
  +++ /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py   2023-05-12 11:46:08.201490083 +0000
  @@ -116,6 +116,7 @@
-          if graceful and self.quitting_rpc_timeout:
-              self.set_rpc_timeout(self.quitting_rpc_timeout)
-          super(CommonAgentLoop, self).stop(graceful)
+          if graceful and self.quitting_rpc_timeout:
+              self.set_rpc_timeout(self.quitting_rpc_timeout)
+          super(CommonAgentLoop, self).stop(graceful)
  +        self.connection.close()
-  
-      def reset(self):
-          common_config.setup_logging()
+ 
+      def reset(self):
+          common_config.setup_logging()

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2019314

Title:
  On shutdown, linuxbridge agent queue on rabbitmq is not cleared

Status in neutron:
  New

Bug description:
  This bug mimics
  https://bugs.launchpad.net/oslo.messaging/+bug/1606213.

  In that bug, the path to oslo_messaging was added, but the close
  method was not called in the linuxbridge agent

  Example patch:

  --- /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py.bak       2023-05-12 11:45:42.089121033 +0000
  +++ /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py   2023-05-12 11:46:08.201490083 +0000
  @@ -116,6 +116,7 @@
           if graceful and self.quitting_rpc_timeout:
               self.set_rpc_timeout(self.quitting_rpc_timeout)
           super(CommonAgentLoop, self).stop(graceful)
  +        self.connection.close()

       def reset(self):
           common_config.setup_logging()

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2019314/+subscriptions