← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2019314] Re: On shutdown, linuxbridge agent queue on rabbitmq is not cleared

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/883685
Committed: https://opendev.org/openstack/neutron/commit/050536c66e4f8cdc6c7aa3ff77c0e9995db5717a
Submitter: "Zuul (22348)"
Branch:    master

commit 050536c66e4f8cdc6c7aa3ff77c0e9995db5717a
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Fri May 19 16:52:16 2023 +0000

    Stop the RPC connections when the agent exits
    
    This behaviour is already present in the OVS agent RPC plugin;
    this patch is imitating that in the ``CommonAgentLoop`` class.
    
    Closes-Bug: #2019314
    Change-Id: I8c87e5ff7b948455c62e2fa2a3c89b8b1e45875c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2019314

Title:
  On shutdown, linuxbridge agent queue on rabbitmq is not cleared

Status in neutron:
  Fix Released

Bug description:
  This bug mimics
  https://bugs.launchpad.net/oslo.messaging/+bug/1606213.

  In that bug, the path to oslo_messaging was added, but the close
  method was not called in the linuxbridge agent

  Example patch:

  --- /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py.bak       2023-05-12 11:45:42.089121033 +0000
  +++ /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py   2023-05-12 11:46:08.201490083 +0000
  @@ -116,6 +116,7 @@
           if graceful and self.quitting_rpc_timeout:
               self.set_rpc_timeout(self.quitting_rpc_timeout)
           super(CommonAgentLoop, self).stop(graceful)
  +        self.connection.close()

       def reset(self):
           common_config.setup_logging()

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2019314/+subscriptions



References