yahoo-eng-team team mailing list archive

[OpenStack Infra <2065145@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/918674
Committed: https://opendev.org/openstack/neutron/commit/5b62e27154c976cfd5707029a94e22e23ecbddef
Submitter: "Zuul (22348)"
Branch:    master

commit 5b62e27154c976cfd5707029a94e22e23ecbddef
Author: Brian Haley <haleyb.dev@xxxxxxxxx>
Date:   Wed May 8 11:44:23 2024 -0400

    Put monitors dictionary back in MetadataDriverBase class
    
    When the common Metadata Driver was created in [0], the
    monitors dictionary was dropped accidentally. This causes
    tracebacks in the fullstack L3-HA tests when
    after_router_updated() is called. Put it back along with
    its related tests.
    
    [0] https://review.opendev.org/c/openstack/neutron/+/894399
    
    Closes-bug: #2065145
    Change-Id: I137ed7cec9e0eafdb3a351e5a414f5a0c16f33e5


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2065145

Title:
  AttributeError: 'MetadataDriver' object has no attribute 'monitors' in
  L3 agent logs

Status in neutron:
  Fix Released

Bug description:
  It is visible in every run of the fullstack job, error is at least in
  the L3 ha agent tests. Stacktrace looks like:

  2024-04-28 03:51:08.699 31321 DEBUG neutron.agent.linux.keepalived [None req-1676808e-ba74-42d7-b46d-044799513cb1 - - - - - -] Keepalived spawned with config /tmp/tmpho4849of/tmpwh6qvjr9/state_pathfza24s3d/ha_confs/8eb06565-5345-45c8-9ae4-80255f3ad42b/keepalived.conf spawn /home/zuul/src/opendev.org/openstack/neutron/neutron/agent/linux/keepalived.py:463
  2024-04-28 03:51:08.701 31321 DEBUG neutron_lib.callbacks.manager [None req-1676808e-ba74-42d7-b46d-044799513cb1 - - - - - -] Publish callbacks ['neutron.agent.metadata.driver.after_router_updated-8766158267284', 'neutron.agent.linux.pd.update_router-8766158297739'] for router (8eb06565-5345-45c8-9ae4-80255f3ad42b), after_update _notify_loop /home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-fullstack-gate/lib/python3.9/site-packages/neutron_lib/callbacks/manager.py:184
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager [None req-1676808e-ba74-42d7-b46d-044799513cb1 - - - - - -] Error during notification for neutron.agent.metadata.driver.after_router_updated-8766158267284 router, after_update: AttributeError: 'MetadataDriver' object has no attribute 'monitors'
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager Traceback (most recent call last):
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager   File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-fullstack-gate/lib/python3.9/site-packages/neutron_lib/callbacks/manager.py", line 189, in _notify_loop
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager     callback.method(resource, event, trigger, payload=payload)
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager   File "/home/zuul/src/opendev.org/openstack/neutron/neutron/agent/metadata/driver.py", line 97, in after_router_updated
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager     if (not proxy.monitors.get(router.router_id) and
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager AttributeError: 'MetadataDriver' object has no attribute 'monitors'
  2024-04-28 03:51:08.701 31321 ERROR neutron_lib.callbacks.manager 

  It could be caused by the
  https://review.opendev.org/c/openstack/neutron/+/894399 but this is
  just my guessing for now.

  I'm not sure how important this bug is really as tests are passing
  fine even with this error but it's for sure better to not have such
  exceptions raised in the logs of the agent :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2065145/+subscriptions