yahoo-eng-team team mailing list archive

[OpenStack Infra <2062573@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/glance/+/916422
Committed: https://opendev.org/openstack/glance/commit/205ca3336a7646ad3fbf92d8cf2509116a10bfcf
Submitter: "Zuul (22348)"
Branch:    master

commit 205ca3336a7646ad3fbf92d8cf2509116a10bfcf
Author: Takashi Kajinami <kajinamit@xxxxxxxxxxxxxxx>
Date:   Fri Apr 19 21:26:24 2024 +0900

    Remove sendfile support
    
    pysendfile[1] was added as an optional dependency but the library
    hasn't been maintained and has got no release since 2014.
    
    What is worse, the sendfile implementation is not actually working
    since The SendFileIterator class was removed[2]. (Follow-up[3] removed
    the remaining reference to the class). The broken implementation has
    not been detected because the client is not currently used to upload
    contents.
    
    Remove the incomplete implementation to get rid of the dependency on
    the unmaintained library.
    
    [1] https://pypi.org/project/pysendfile/
    [2] 76c3620c7effb15be577450c276db1e394c2de3e
    [3] 0c151d7d7ea00627fad182898958db55b1fef3fd
    
    Closes-Bug: #2062573
    Change-Id: Ia4784f59d16660e8d40c0e409f092ac4e46870b4


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/2062573

Title:
  pysendfile library is unmaintained

Status in Glance:
  Fix Released

Bug description:
  The pysendfile library[1] was added as an optimal dependency for zero-
  copy image upload[2] but the library got no release for 10 years.

  We should consider replacing it by os.sendfile or removing the feature
  instead of using the unmaintained library.

  [1] https://pypi.org/project/pysendfile/
  [2] https://review.opendev.org/c/openstack/glance/+/3863

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/2062573/+subscriptions