yahoo-eng-team team mailing list archive

[OpenStack Infra <2085447@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/933132
Committed: https://opendev.org/openstack/neutron/commit/a03afc1bc2d855e66633228fdfd5797c7414b39c
Submitter: "Zuul (22348)"
Branch:    master

commit a03afc1bc2d855e66633228fdfd5797c7414b39c
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Mon Oct 21 22:21:55 2024 +0000

    Exit fast checking the external network default
    
    If the network is not external, there is no need to check
    if there is an associated ``externalnetwork`` register.
    
    Closes-Bug: #2085447
    Change-Id: I54de12dd8df99c605bf3da6dea4c6c5a074e3b86


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2085447

Title:
  Fast exit ``_ensure_external_network_default_value_callback`` if
  network not external

Status in neutron:
  Fix Released

Bug description:
  The method ``_ensure_external_network_default_value_callback`` [1] can
  fast exit if the network request is not for an external network. That
  will save one DB query [2].

  [1]https://github.com/openstack/neutron/blob/9347c427b5354b608c61b11d29aebff889cd0213/neutron/services/auto_allocate/db.py#L43-L79
  [2]https://github.com/openstack/neutron/blob/9347c427b5354b608c61b11d29aebff889cd0213/neutron/services/auto_allocate/db.py#L72-L73

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2085447/+subscriptions