yahoo-eng-team team mailing list archive

[OpenStack Infra <2092907@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/938800
Committed: https://opendev.org/openstack/neutron/commit/9a0814c760777e53c9499bb3a891f436d34f3bee
Submitter: "Zuul (22348)"
Branch:    master

commit 9a0814c760777e53c9499bb3a891f436d34f3bee
Author: Gaudenz Steinlin <gaudenz.steinlin@xxxxxxxxxxxxx>
Date:   Thu Jan 9 18:09:27 2025 +0100

    Fixup conntrackd support
    
    This contains several fixups for which did not make it into the original
    change before it got merged:
    
    * Removal of the GPL licensed shell script. This is replaced by Python
      code in neutron-keepalived-state-change. This code was rewritten from
      scratch and is Apache licensed.
    * Addition of the conntrackd package to bindep.txt for tests. This
      properly documents this new test requirement.
    * Several typo and other small fixes suggested by Ihar Hrachyshka.
    * Common pgrep utility function as suggested by lajoskatona.
    
    Closes-Bug: #2092907
    Change-Id: Ica1c38b3a635d60a08f48272fcda2034b0323d10


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2092907

Title:
  Potential GPL violation in master branch due to GPL script embedded
  into Apache2 python code

Status in neutron:
  Fix Released

Bug description:
  conntrackd support was merged in master; it includes a GPL script
  taken from an external source that is embedded in Python code as a
  string. The Python code is in Apache2. I think this melding-in
  effectively applies GPL to neutron code, which is wrong.

  I think the correct approach is to put the script under GPL into an
  external file and then load it from disc as needed.

  See
  https://review.opendev.org/c/openstack/neutron/+/917430/comment/009f9f98_40027b0c/
  where I point out the issue and suggest a solution.

  I think this should be a blocker for the next release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2092907/+subscriptions