yahoo-eng-team team mailing list archive

[OpenStack Infra <2100806@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/944950
Committed: https://opendev.org/openstack/neutron/commit/bcbde77444bc8cf721c5c2329208ad9c12ff3cba
Submitter: "Zuul (22348)"
Branch:    master

commit bcbde77444bc8cf721c5c2329208ad9c12ff3cba
Author: Brian Haley <haleyb.dev@xxxxxxxxx>
Date:   Tue Mar 18 17:02:45 2025 -0400

    Remove flaky batch notifier unit test
    
    The test_queue_event_multiple_events_notify_method()
    can be flaky depending on the performance of the SUT,
    where sometimes the notifier is called thrice instead
    of the expected twice, making in unreliable. As we are
    already testing all the notification events arrived in
    test_queue_event_multiple_events_callback_method(),
    let's remove the other test.
    
    Closes-bug: #2100806
    Change-Id: I193b4cba5b31ff9baa90992a11db70e5b65ec569


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2100806

Title:
  Intermittent test_batch_notifier failure

Status in neutron:
  Fix Released

Bug description:
  The cross-neutron-py12 job was intermittently failing in the
  requirements repo:

  https://review.opendev.org/c/openstack/requirements/+/942959

  Below is the failure:

  ==============================
  Failed 1 tests - output below:
  ==============================

  neutron.tests.unit.notifiers.test_batch_notifier.TestBatchNotifier.test_queue_event_multiple_events_notify_method
  -----------------------------------------------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):

        File
  "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py",
  line 178, in func

      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^

        File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/unit/notifiers/test_batch_notifier.py", line 66, in test_queue_event_multiple_events_notify_method
      self.assertEqual(2, c_mock.call_count)

        File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py312/lib/python3.12/site-packages/testtools/testcase.py", line 419, in assertEqual
      self.assertThat(observed, matcher, message)

        File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py312/lib/python3.12/site-packages/testtools/testcase.py", line 509, in assertThat
      raise mismatch_error

      testtools.matchers._impl.MismatchError: 2 != 3

  
  This test and code was recently updated to remove eventlet, and it was noted that the test is timing-sensitive, so at the CI meeting we agreed to increase the sleep in the test from zero (to just trigger a yield) to either 0.1 or 0.2 to let the consumer execute. This bug is to track that work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2100806/+subscriptions