← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2121609] Re: flake8 plugins from neutron-lib are enabled by default, breaking existing projects dependent on it

 

Reviewed:  https://review.opendev.org/c/openstack/neutron-lib/+/958786
Committed: https://opendev.org/openstack/neutron-lib/commit/d1f6c22cb07f76a2ce1a847824dcb62b5a22e2e3
Submitter: "Zuul (22348)"
Branch:    master

commit d1f6c22cb07f76a2ce1a847824dcb62b5a22e2e3
Author: Takashi Kajinami <kajinamit@xxxxxxxxxxxxxxx>
Date:   Fri Aug 29 01:57:07 2025 +0900

    Disable flake8 plugins by default
    
    Since 9b6a1aafc394df6e29cde3534167e53279f727f6 was merged, all plugins
    provided by neutron-lib are enabled automatically, as long as
    neutron-lib is enabled.
    
    This is a breaking change for any projects using neutron-lib,
    especially ones outside of neutron's governance. While technically
    we can ignore these checks, it'd be better to explicitly opt-in to
    these checks to make sure new checks do not break pep8 check
    immediately.
    
    Closes-Bug: #2121609
    Change-Id: I3a592f6170ab5215c1e0f2ebd7b9778141689932
    Signed-off-by: Takashi Kajinami <kajinamit@xxxxxxxxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2121609

Title:
  flake8 plugins from neutron-lib are enabled by default, breaking
  existing projects dependent on it

Status in neutron:
  Fix Released

Bug description:
  neutron-lib 3.21.1 added entrypoints for local hacking plugins.
  Because all plugins have no off_by_default set, these are enabled if the neutron-lib plugin is installed.
  This may work for projects inside neutron, but there are a few other projects (like networking-generic-switch under ironic's governance or heat using it for validation) using neutron-lib are "forced" to follow the neutron's standard or maintain ignore list.

  https://review.opendev.org/c/openstack/neutron-lib/+/956353

  Note that we don't really these plugins exposed via entry points,
  becasue we can load plugins via local-plugins definition.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2121609/+subscriptions



References