yahoo-eng-team team mailing list archive

[OpenStack Infra <2125052@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/961673
Committed: https://opendev.org/openstack/nova/commit/dedfc305ddc1ab23365698469bb1552edf0613e4
Submitter: "Zuul (22348)"
Branch:    master

commit dedfc305ddc1ab23365698469bb1552edf0613e4
Author: Sylvain Bauza <sbauza@xxxxxxxxxx>
Date:   Thu Sep 18 16:25:50 2025 +0200

    Add admin context when filling metadata on ImagePropsWeigher
    
    Creating a new admin context as we can't reuse the RequestSpec user
    context in order to hydrate InstanceList with the full list of instances
    from the host and not only the ones from the user.
    
    Closes-Bug: #2125052
    
    Change-Id: Ibbd80324c17be6546ecd8b80f908ac5bbab5abd0
    Signed-off-by: Sylvain Bauza <sbauza@xxxxxxxxxx>


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2125052

Title:
  ImageProps weigher returns an exception after starting a second
  instance

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When starting a first instance on a host, the ImageProps weigher works
  correctly, but when scheduling a second instance on it, then it
  returns an exception due to a missing context :

  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server [None req-d611c529-7c8b-48f5-8465-5fe61d98eac4 ccdbae8178a34f08935c74eca6d6f29c fb742349a3944923b9232fdc303a7a8b - - default default] Exception during message handling: AttributeError: 'NoneType' object has no attribute 'is_admin'
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/server.py", line 165, in _process_incoming
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     res = self.dispatcher.dispatch(message)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/dispatcher.py", line 309, in dispatch
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     return self._do_dispatch(endpoint, method, ctxt, args)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/dispatcher.py", line 229, in _do_dispatch
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     result = func(ctxt, **new_args)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/server.py", line 244, in inner
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     return func(*args, **kwargs)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/scheduler/manager.py", line 224, in select_destinations
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     selections = self._select_destinations(
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/scheduler/manager.py", line 251, in _select_destinations
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     selections = self._schedule(
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/scheduler/manager.py", line 388, in _schedule
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     hosts = self._get_sorted_hosts(spec_obj, hosts, num)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/scheduler/manager.py", line 680, in _get_sorted_hosts
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     weighed_hosts = self.host_manager.get_weighed_hosts(
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/scheduler/host_manager.py", line 622, in get_weighed_hosts
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     return self.weight_handler.get_weighed_objects(self.weighers,
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/weights.py", line 134, in get_weighed_objects
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     weights = weigher.weigh_objects(weighed_objs, weighing_properties)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/weights.py", line 110, in weigh_objects
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     weight = self._weigh_object(obj.obj, weight_properties)
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/scheduler/weights/image_props.py", line 74, in _weigh_object
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     insts.fill_metadata()
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/objects/instance.py", line 1542, in fill_metadata
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     updates = db.instances_fill_metadata(
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/db/utils.py", line 34, in wrapper
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     nova.context.require_context(args[0])
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server   File "/usr/lib/python3.9/site-packages/nova/context.py", line 296, in require_context
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server     if not ctxt.is_admin and not is_user_context(ctxt):
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server AttributeError: 'NoneType' object has no attribute 'is_admin'
  2025-09-17 18:07:47.899 1 ERROR oslo_messaging.rpc.server ^[[00m

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2125052/+subscriptions