← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2125935] Re: ImageProps weigher is not able to find the existing image properties

 

Reviewed:  https://review.opendev.org/c/openstack/nova/+/963358
Committed: https://opendev.org/openstack/nova/commit/98885344bd93531d569ded3f4492f473b09d0614
Submitter: "Zuul (22348)"
Branch:    master

commit 98885344bd93531d569ded3f4492f473b09d0614
Author: Sylvain Bauza <sbauza@xxxxxxxxxx>
Date:   Tue Sep 30 16:08:57 2025 +0200

    Fix fill_metadata usage for the ImagePropertiesWeigher
    
    When using the weigher, we need to target the right cell context for the
    existing instances in the host.
    fill_metadata was also having an issue as we need to pass the dict value
    from the updated dict by keying the instance uuid, not the whole dict of
    updated instances.
    
    Change-Id: I18260095ed263da4204f21de27f866568843804e
    Closes-Bug: #2125935
    Signed-off-by: Sylvain Bauza <sbauza@xxxxxxxxxx>


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2125935

Title:
  ImageProps weigher is not able to find the existing image properties

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When configuring ImagePropsWeigher, the weight value is always equal
  to 0 even if existing instances have the same requested image
  properties.

  This is due to the fact that
  https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/scheduler/weights/image_props.py#L80C15-L80C28
  is unable to access the cell database as there is no cell context
  target.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2125935/+subscriptions



References