yellow team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

On 05/04/2011 08:29 PM, Benji York wrote:
> On Wed, May 4, 2011 at 4:48 AM, Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx> wrote:
>>> 3) We need some CSS lovin' to pretty-up some accordion panels.  To view, go to someplace like https://bugs.edge.launchpad.net/launchpad-project/+bugs , click "Subscribe to bug mail," choose "are added or changed in any way," choose "Bugs must match this filter," and then expand the three parts of that accordion pane.  An incomplete list of things that are unattractive: Select all and Select none should be green and should have more space between them; and options should have more padding around them on the edge of the accordion.  It just doesn't look polished in there.  JS is making all of that, so if digging into the code is too much work, feel free to give us a photoshop of what you think we should do, or something along those lines.  CSS pointers for achieving what you want will always be appreciated, though.
>> I've hit a bunch of issues with this which means there's a lot of work
>> to get this done. It would be great if someone has some time to rewrite
>> how the checkboxes are generated and get it to return valid html. I will
>> do it if it's not done by the time I get back at the end of next week.
> I've looked at this and can't see anything particularly bad about the
> generated HTML.  If you can tell me what in particular you need changed
> (either here or in a bug) I'll be glad to fix it.
The output I get is a table with a bunch of <td>s but the actual
contents (<label>s if I remember correctly) are not in those cells but
rather directly in the <table>. Don't worry about it, I want to rewrite
it as a <ul> anyway so I will do it in a week or so.