yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Review: Approve

Cool, Brad!

I think rearranging a bit in config-changed would be nicer, but this is just a suggestion:

103	+config = get_config()
117	+log(str(config))
123	+# If all of the required keys are not present in the configuration then exit
124	+# with an error.
125	+if not all(config.get(k) for k in REQUIRED_KEYS):
126	+    log('All required items not configured: {}'.format(REQUIRED_KEYS))
128	+    sys.exit(1)
105	+
104	+prev_config = load_pickle(CONFIG_PICKLE)
106	+diff = DictDiffer(config, prev_config)
119	+if not diff.modified:
120	+    log("No configuration changes, exiting.")
121	+    sys.exit(0)
115	 
116	 log('Updating buildbot configuration.')
129	+
130	+log('Configuration changes seen:')
131	+log(str(diff))
107	+
108	+buildbot_pkg = config.get('buildbot-pkg')
109	+buildbot_dir =  config.get('installdir')
110	+config_file = config.get('config-file')
111	+config_transport = config.get('config-transport')
112	+config_url = config.get('config-url')
113	+extra_repo = config.get('extra-repository')
114	+extra_pkgs = config.get('extra-packages')

Maybe we should just delete this?

441	+## run('buildbot', 'create-master', buildbot_dir)
442	+## shutil.copyfile(os.path.join(buildbot_dir, 'master.cfg.sample'),
443	+##                 os.path.join(buildbot_dir, 'master.cfg'))

It looks very good!

Thanks
-- 
https://code.launchpad.net/~bac/charms/oneiric/buildbot-master/wip/+merge/91357
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk.