yellow team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Review: Approve code

Hi Benji,

Some of this code already landed in my branch.  Hope that doesn't complicate things.

Also, the branch I landed for gmb and frankban made changes to unit_info.  You may want to look at what is in trunk before attempting the merge.

As we discussed this morning there is a move afoot to follow more of PEP-8 than LP coding style so perhaps you could update the tests to getRidOfCamelCase in_favor_of_underscores?

typo: occurs not ocurrs

redundant not redunant

There is now an 'encode_file' helper if you want to use it.


-- 
https://code.launchpad.net/~benji/charms/oneiric/buildbot-master/more-tests/+merge/92123
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk.