yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

The proposal to merge lp:~frankban/lpsetup/use-lxcip into lp:lpsetup has been updated.

Description changed to:

== Changes ==

lpsetup no longer changes resolv.conf and dhcp files.
Each ssh connection is made using the container's ip address, obtained from *lp-lxc-ip*.

Changed the lxc template filename, and how the bridge interface is retrieved: now the script looks for interface existence: lxcbr0 first, virbr0 as a fallback, error otherwise (see get_lxc_gateway).

Fixed the script error handling: now lpsetup exists with the expected return code.

Removed the `wait_for_lxc` step: each ssh call systematically retries to obtain the ip address and establish the connection, for ~30 seconds.


== Tests ==

$ nosetests
........................................................
Name                  Stmts   Miss  Cover   Missing
---------------------------------------------------
lpsetup                   6      1    83%   16
lpsetup.argparser       125      6    95%   113, 221, 278-279, 298, 307
lpsetup.exceptions        6      0   100%
lpsetup.handlers         55      1    98%   55
lpsetup.settings         29      0   100%
lpsetup.subcommands       0      0   100%
lpsetup.utils           125     28    78%   80, 114-124, 132-133, 148, 199, 209, 230-232, 250-256, 275-277
---------------------------------------------------
TOTAL                   346     36    90%
----------------------------------------------------------------------
Ran 56 tests in 0.579s

OK

For more details, see:
https://code.launchpad.net/~frankban/lpsetup/use-lxcip/+merge/104350
-- 
https://code.launchpad.net/~frankban/lpsetup/use-lxcip/+merge/104350
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~frankban/lpsetup/use-lxcip into lp:lpsetup.