← Back to team overview

yellow team mailing list archive

Thread
Date

Re: [Merge] lp:~yellow/subunit/on_filter into lp:subunit

To: Gary Poster <gary.poster@xxxxxxxxxxxxx>
From: Robert Collins <robertc@xxxxxxxxxxxxxxxxx>
Date: Wed, 02 May 2012 09:59:26 -0000
In-reply-to: <20120428023117.20738.6637.launchpad@ackee.canonical.com>
Reply-to: mp+103968@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

The count thing in testrepository is best solved by using MultiTestResult and forking the streams rather than fiddling with internals in the filter; the comment in the existing class there explains this.
-- 
https://code.launchpad.net/~yellow/subunit/on_filter/+merge/103968
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/subunit/on_filter.

References

[Merge] lp:~yellow/subunit/on_filter into lp:subunit
From: Gary Poster, 2012-04-28