← Back to team overview

yellow team mailing list archive

Re: Filter buttons should match design (issue 6733060)

 

I think this looks pretty good, with the minor below.  This is just a
trainee review.


https://codereview.appspot.com/6733060/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6733060/diff/1/lib/views/stylesheet.less#newcode878
lib/views/stylesheet.less:878: div:nth-child(6) {
This might be better using the :last-child pseudoselector, as much of
the work in the view is related to making the amount of filter buttons
data driven (and the stylesheet has no knowledge of that)

https://codereview.appspot.com/6733060/

-- 
https://code.launchpad.net/~tveronezi/juju-gui/filter-buttons/+merge/130832
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/filter-buttons into lp:juju-gui.


References