← Back to team overview

yellow team mailing list archive

Re: Ambiguous relation improvements (issue 6765050)

 

LGTM


https://codereview.appspot.com/6765050/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6765050/diff/1/app/views/environment.js#newcode1478
app/views/environment.js:1478: return a[0].name + a[1].name < b[0].name
+ b[1].name;
Kapil may still want a different sort order here, but I expect this is
fine as it meets the goal of being consistent.

https://codereview.appspot.com/6765050/

-- 
https://code.launchpad.net/~makyo/juju-gui/ambiguous-minors/+merge/131325
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/ambiguous-minors into lp:juju-gui.


References