yellow team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

Review: Needs Fixing

It doesn't look like you used lbox for this, but I'm including a reply here.

http://yuilibrary.com/yui/docs/event/key.html has a key filtering spec

such that we can say things like 

// require modifier keys with +(modifier)
Y.one('doc').on('key', composeMail, 'n+ctrl');

This seems to meet our needs here and will eliminate much of the code included in this diff. This way we can fire directly to handlers w/o multiple events per keydown to do indirection like you have now. 

Looking forward to having keyboard shortcuts :)

-- 
https://code.launchpad.net/~tveronezi/juju-gui/hotkeys/+merge/131382
Your team Juju GUI Hackers is subscribed to branch lp:juju-gui.