yellow team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

LGTM, nice feature.


https://codereview.appspot.com/6766052/diff/1/app/views/environment.js
File app/views/environment.js (left):

https://codereview.appspot.com/6766052/diff/1/app/views/environment.js#oldcode1300
app/views/environment.js:1300: if (service) {
Your other branch add the check for a valid cp, make sure that gets
included here, we can currently getClientRects of null and fail out.

https://codereview.appspot.com/6766052/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6766052/diff/1/app/views/environment.js#newcode1310
app/views/environment.js:1310: cp.addClass('right');
minor but, these calls are chainable.

https://codereview.appspot.com/6766052/

-- 
https://code.launchpad.net/~makyo/juju-gui/menu-positioning/+merge/131384
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/menu-positioning into lp:juju-gui.