yellow team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Thanks Thiago.  This is another nice interim branch on the way to our
simplified build story.


https://codereview.appspot.com/6853044/diff/9001/bin/merge-files
File bin/merge-files (right):

https://codereview.appspot.com/6853044/diff/9001/bin/merge-files#newcode34
bin/merge-files:34: thirdPartyCSS;
Thanks for taking Matt's suggestion.  Acronyms in camelCase are always
tricky but I actually prefer this way.  It does get ugly if another word
follows the acronym, though, e.g. thirdPartyCSSFile.

https://codereview.appspot.com/6853044/diff/9001/lib/server.js
File lib/server.js (right):

https://codereview.appspot.com/6853044/diff/9001/lib/server.js#newcode15
lib/server.js:15: * It finds a file under the given path. The first
match wins.
I'd rewrite as "Find a file" to be non-passive.

https://codereview.appspot.com/6853044/

-- 
https://code.launchpad.net/~tveronezi/juju-gui/combinecss/+merge/134140
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/combinecss into lp:juju-gui.