yellow team mailing list archive
-
yellow team
-
Mailing list archive
-
Message #01650
Re: Fix overflow on charm name. (issue 6843082)
Thanks bac. It looks good.
I have just a minor comment. But I think it is out of the scope of this
card.
[]s,
Thiago.
https://codereview.appspot.com/6843082/diff/2001/app/templates/charm-search-result.handlebars
File app/templates/charm-search-result.handlebars (right):
https://codereview.appspot.com/6843082/diff/2001/app/templates/charm-search-result.handlebars#newcode15
app/templates/charm-search-result.handlebars:15: <a class="charm-detail"
It is out of the scope of this card but IMO you could add a tooltip with
the complete charm name (no elipsis) if possible.
https://codereview.appspot.com/6843082/
--
https://code.launchpad.net/~bac/juju-gui/charm-spill/+merge/134961
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/charm-spill into lp:juju-gui.
References