yellow team mailing list archive

[Matthew Scott <matthew.scott@xxxxxxxxxxxxx>]

Thanks Ben and Gary!

As to the card about ENV=1 flags to make, I understand, and I'll make a
card to discuss this on Friday.


https://codereview.appspot.com/6873071/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6873071/diff/1/Makefile#newcode13
Makefile:13: JSFILES=$(shell find . -wholename './node_modules*' -prune
\
I agree that it would be nice to have this be more positive, but I also
agree that it probably needs to be in a card of its own that moves some
files around.  It'd be clearer to just specify valid directories, but
now things are kind of scattered.  I'll make a card.

On 2012/12/13 04:02:59, benjamin.saller wrote:
> Looking at how this is used (and I realize its pre-existing) I think
it might be
> better to make a clearer separation of runtime vs devel files. I'd
also suggest
> we clearly move
> 3rd party libs away from our libraries,
> app/assets/javascripts/3rd-party.


> This could lead to simpler rules.

> find app -name \*.js | grep -e app/assets/javascipts/third-party/

> might yield the runtime files.

> I don't think we need to do this now, but I think we should make a
card.

https://codereview.appspot.com/6873071/diff/1/Makefile#newcode13
Makefile:13: JSFILES=$(shell find . -wholename './node_modules*' -prune
\
On 2012/12/12 22:20:07, gary.poster wrote:
> Before this, I think we need a comment explaining the two use cases
for not
> using bzr commands: we want to make releases without bzr access, so
working with
> a branch is fast; and we want to allow devs to work with a release
(per Kapil; I
> really don't like this.  devs should work with a branch.)

Done.

https://codereview.appspot.com/6873071/diff/1/Makefile#newcode19
Makefile:19: -o -name '*generateTemplates' \
On 2012/12/12 22:20:07, gary.poster wrote:
> This could simply be 'generateTemplates', without the wildcard.

Done.

https://codereview.appspot.com/6873071/diff/1/Makefile#newcode102
Makefile:102: TEMPLATE_TARGETS=$(shell find app/templates -type f
-print)
On 2012/12/12 22:20:07, gary.poster wrote:
> Please exclude standard editor effluvia.

Done.

https://codereview.appspot.com/6873071/diff/1/Makefile#newcode104
Makefile:104: SPRITE_SOURCE_FILES=$(shell find app/assets/images -type f
-print)
On 2012/12/12 22:20:07, gary.poster wrote:
> Please exclude standard editor effluvia.

Done.

https://codereview.appspot.com/6873071/

-- 
https://code.launchpad.net/~makyo/juju-gui/bzr-make-1086794/+merge/139518
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/bzr-make-1086794 into lp:juju-gui.