yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/juju-gui/bug-1092183-missing-version into lp:juju-gui.

Requested reviews:
  Juju GUI Hackers (juju-gui)
Related bugs:
  Bug #1092183 in juju-gui: "The stable release tarball is missing the version number"
  https://bugs.launchpad.net/juju-gui/+bug/1092183

For more details, see:
https://code.launchpad.net/~frankban/juju-gui/bug-1092183-missing-version/+merge/140715

Fixed version number missing in stable release.

Now the tarball file name correctly includes the version.

https://codereview.appspot.com/6965048/

-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1092183-missing-version/+merge/140715
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1092183-missing-version into lp:juju-gui.

=== modified file 'Makefile'
--- Makefile	2012-12-19 12:09:20 +0000
+++ Makefile	2012-12-19 16:12:21 +0000
@@ -64,7 +64,7 @@
     $(error FINAL releases must have a most-recent version number other than \
 	"unreleased" in CHANGES.yaml)
 endif
-VERSION=$(ULTIMATE_VERSION)
+RELEASE_VERSION=$(ULTIMATE_VERSION)
 SERIES=stable
 else
 # If this is development (non-FINAL) release, then the most recent version