yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Reviewers: mp+140715_code.launchpad.net,

Message:
Please take a look.

Description:
Fixed version number missing in stable release.

Now the tarball file name correctly includes the version.

https://code.launchpad.net/~frankban/juju-gui/bug-1092183-missing-version/+merge/140715

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/6965048/

Affected files:
   M Makefile
   A [revision details]


Index: Makefile
=== modified file 'Makefile'
--- Makefile	2012-12-19 12:09:20 +0000
+++ Makefile	2012-12-19 16:08:09 +0000
@@ -64,7 +64,7 @@
      $(error FINAL releases must have a most-recent version number other  
than \
  	"unreleased" in CHANGES.yaml)
  endif
-VERSION=$(ULTIMATE_VERSION)
+RELEASE_VERSION=$(ULTIMATE_VERSION)
  SERIES=stable
  else
  # If this is development (non-FINAL) release, then the most recent version


Index: [revision details]
=== added file '[revision details]'
--- [revision details]	2012-01-01 00:00:00 +0000
+++ [revision details]	2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:  
francesco.banconi@xxxxxxxxxxxxx-20121219133154-dyq1q2z2iuo23xz2
+New revision:  
francesco.banconi@xxxxxxxxxxxxx-20121219160809-3efjm55sttle2f04




-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1092183-missing-version/+merge/140715
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1092183-missing-version into lp:juju-gui.