yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

This looks great Francesco. :-)

I suggest that you ignore my bzr: idea (see below).  We can add that if
we want it later.

I'm running tests for Nicola's branch now. I'll give your branch a try
after that, and then give an official blessing.


https://codereview.appspot.com/6977043/diff/1/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/6977043/diff/1/hooks/utils.py#newcode131
hooks/utils.py:131: if source.startswith('lp:') or
source.startswith('http://'):
I wonder if we should support bzr: too.  Might be nice.  No biggie.

https://codereview.appspot.com/6977043/diff/1/tests/test_utils.py
File tests/test_utils.py (right):

https://codereview.appspot.com/6977043/diff/1/tests/test_utils.py#newcode85
tests/test_utils.py:85: # Ensure the factory return the expected object
instances.
typo: returns

https://codereview.appspot.com/6977043/

-- 
https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1088618-serve-releases/+merge/140745
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/charms/precise/juju-gui/bug-1088618-serve-releases into lp:~juju-gui/charms/precise/juju-gui/trunk.