yellow team mailing list archive

[Matthew Scott <matthew.scott@xxxxxxxxxxxxx>]

Reviewers: mp+142202_code.launchpad.net,

Message:
Please take a look.

Description:
Prevent duplicate nodes in services.

drawService was being called for all nodes on update, which was
appending new nodes to the DOM (for the most part invisibly, but still
not good).  Instead, new services are filled with the empty requisites
for a service block, and then the internals are updated on update to
match the DB.  A further step (not taken here for time's sake) would be
to only update services affected by the update call.  Additionally, some
comments were out of date, and these were cleaned up.

https://code.launchpad.net/~makyo/juju-gui/duplicates-1095761/+merge/142202

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/7066050/

Affected files:
   A [revision details]
   M app/views/topology/mega.js
   M undocumented



-- 
https://code.launchpad.net/~makyo/juju-gui/duplicates-1095761/+merge/142202
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/duplicates-1095761 into lp:juju-gui.