yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Land with changes

Hi Matt.  Looks good to me.  Thank you for the simplifications.  I have
trivial indentation suggestions that you may ignore if desired.

Did you consider whether we could test this so it would not happen
again?  That would be nice.

Thanks

Gary


https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js
File app/views/topology/mega.js (left):

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldcode408
app/views/topology/mega.js:408: })
FWIW, this indentation looked nicer to me.

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldcode463
app/views/topology/mega.js:463: })
nicer indent here.

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldcode466
app/views/topology/mega.js:466: })
this indentation is nicer here too, I think.

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldcode483
app/views/topology/mega.js:483: })
nicer indent before

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldcode486
app/views/topology/mega.js:486: })
nicer indent before

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldcode591
app/views/topology/mega.js:591: });
indent was nicer before I think.

https://codereview.appspot.com/7066050/diff/1/undocumented
File undocumented (left):

https://codereview.appspot.com/7066050/diff/1/undocumented#oldcode210
undocumented:210: app/views/topology/mega.js:378 "drawService"
thank you!

https://codereview.appspot.com/7066050/

-- 
https://code.launchpad.net/~makyo/juju-gui/duplicates-1095761/+merge/142202
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/duplicates-1095761 into lp:juju-gui.